Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: support (de)serialization of DOMException #57372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jazelly
Copy link
Member

@jazelly jazelly commented Mar 8, 2025

Added serialization and deserialization support for DOMException. Ideally we shouldn't do this in native, but since it's compiled before an Environment exists, we cannot mark it as JSTransferrable and provide associated serialization methods in JS land.

Fixes: #49181

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 8, 2025
@jazelly jazelly force-pushed the serialize-dom-exception branch 2 times, most recently from c73bc7f to b039fee Compare March 8, 2025 03:12
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 75.20000% with 31 lines in your changes missing coverage. Please review.

Project coverage is 90.21%. Comparing base (3a497dc) to head (96f824c).

Files with missing lines Patch % Lines
src/node_messaging.cc 75.20% 12 Missing and 19 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57372      +/-   ##
==========================================
- Coverage   90.22%   90.21%   -0.01%     
==========================================
  Files         630      630              
  Lines      185259   185381     +122     
  Branches    36245    36270      +25     
==========================================
+ Hits       167143   167238      +95     
- Misses      11063    11068       +5     
- Partials     7053     7075      +22     
Files with missing lines Coverage Δ
src/node_messaging.cc 82.67% <75.20%> (-0.80%) ⬇️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jazelly jazelly force-pushed the serialize-dom-exception branch from b039fee to 0aec3cf Compare March 8, 2025 08:14
@jazelly jazelly force-pushed the serialize-dom-exception branch from 0aec3cf to 96f824c Compare March 8, 2025 08:42
@jazelly jazelly requested review from legendecas and addaleax March 9, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stucturedClone defective for DataCloneError
2 participants