sqlite: allow setting defensive flag

[louwers]

Adds support for setting the defensive flag. See SQLITE_DBCONFIG_DEFENSIVE.

This is one of the APIs needed for Defense Against The Dark Arts when dealing with untrusted SQL queries. Another being the sqlite3_limit() interface, which may be a neat future addition.

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[Renegade334]

IMO it'd be worth considering setting this to enabled by default, either here or in a future semver-major change. >99% of users will have no need to alter engine-level internals.

[louwers]

@Renegade334 Good point. I think it makes sense to just set defensive as the default here since the SQLite API is experimental and you almost never want to mess with those indeed.

better-sqlite3 does the same. https://github.com/WiseLibs/better-sqlite3/blob/ea0d8c73615ce2b6133df67da10c7e6452115d73/docs/unsafe.md?plain=1#L5

[louwers]

@Renegade334 Enabled it by default.

This PR should have a notable-change label.

[codecov]

Codecov Report

❌ Patch coverage is 68.57143% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.55%. Comparing base (f9fcc74) to head (af87669).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	65.62%	4 Missing and 7 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60217      +/-   ##
==========================================
- Coverage   88.56%   88.55%   -0.02%     
==========================================
  Files         704      704              
  Lines      208125   208158      +33     
  Branches    40003    40010       +7     
==========================================
- Hits       184332   184329       -3     
- Misses      15809    15858      +49     
+ Partials     7984     7971      -13     

Files with missing lines	Coverage Δ
src/node_sqlite.h	81.48% <100.00%> (+1.08%)	⬆️
src/node_sqlite.cc	79.94% <65.62%> (-0.21%)	⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[louwers]

How do I add a comment for the Notable Changes section?

[aduh95]

How do I add a comment for the Notable Changes section?

Wouldn't the notable change be the follow-up PR rather than this one?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69701/

[louwers]

@aduh95 That works too!

[louwers]

Could someone restart CI? Looks like a fluke.