Skip to content

Conversation

mag123c
Copy link

@mag123c mag123c commented Oct 12, 2025

Fixes: #59417

Implements classname hierarchy for the JUnit XML reporter.
Previously, all tests had classname="test".
Now the classname reflects the suite hierarchy (e.g., classname="Math.Addition" for nested suites).

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 12, 2025
@atlowChemi atlowChemi requested review from MoLow and pmarchini October 12, 2025 20:10
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (e105e82) to head (f738875).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60220      +/-   ##
==========================================
+ Coverage   88.53%   88.57%   +0.04%     
==========================================
  Files         704      704              
  Lines      208087   208140      +53     
  Branches    40006    40013       +7     
==========================================
+ Hits       184223   184358     +135     
+ Misses      15869    15808      -61     
+ Partials     7995     7974      -21     
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 97.39% <100.00%> (+0.02%) ⬆️
lib/internal/test_runner/tests_stream.js 90.11% <100.00%> (+0.11%) ⬆️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mag123c mag123c force-pushed the feature/junit-classname-hierarchy branch from f738875 to 5e2a5d3 Compare October 13, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't set classname for testcase element in JUnit XML when using node:test

3 participants