Skip to content

Conversation

tarunbatra
Copy link
Contributor

Fixes: #59938

Fixes an issue where when navigating a multiline input which exceeds terminal height, pressing UP arrow would not update the visible data when the cursor reaches the top.

Demo

Before After
before after

Tests

In Progress. I am still figuring out how to test the REPL screen rendering in response to cursor movements.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels Oct 12, 2025
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

❌ Patch coverage is 48.38710% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.54%. Comparing base (da9cd74) to head (d7f3462).

Files with missing lines Patch % Lines
lib/internal/readline/interface.js 48.38% 15 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60222      +/-   ##
==========================================
- Coverage   88.56%   88.54%   -0.03%     
==========================================
  Files         704      704              
  Lines      208123   208150      +27     
  Branches    40014    40017       +3     
==========================================
- Hits       184330   184310      -20     
- Misses      15815    15874      +59     
+ Partials     7978     7966      -12     
Files with missing lines Coverage Δ
lib/internal/readline/interface.js 96.39% <48.38%> (-0.94%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Fixes an issue where when navigating a multiline input which exceeds
terminal height, pressing UP arrow would not update the visible data
when the cursor reaches the top.

Fixes: nodejs#59938
@tarunbatra tarunbatra force-pushed the repl-multiline-refresh branch from 4402b1a to d7f3462 Compare October 12, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

REPL cursor in big input 'stops' at top visible line

2 participants