sqlite: improve error reporting for prepared statements in SQLTagStore #60227
+60
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
louwers
reviewed
Oct 12, 2025
|
|
||
| test('failed prepares throw', () => { | ||
| assert.throws(() => { | ||
| sql.all`SELECT * FROM does_not_exist`; // eslint-disable-line no-unused-expressions |
There was a problem hiding this comment.
Consider configuring eslint with https://eslint.org/docs/latest/rules/no-unused-expressions#allowtaggedtemplates
There was a problem hiding this comment.
I have updated the ESLint configuration.
louwers
reviewed
Oct 12, 2025
src/node_sqlite.cc
Outdated
| Local<String> js_errstr; | ||
| Local<String> js_errmsg; | ||
| Local<Object> e; | ||
| if (!String::NewFromUtf8(isolate, errstr).ToLocal(&js_errmsg) || |
There was a problem hiding this comment.
Need to be swapped.
Suggested change
| if (!String::NewFromUtf8(isolate, errstr).ToLocal(&js_errmsg) || | |
| if (!String::NewFromUtf8(isolate, errstr).ToLocal(&js_errstr) || |
There was a problem hiding this comment.
Oh sorry, that was my mistake.
louwers
reviewed
Oct 12, 2025
| message: 'Failed to prepare statement', | ||
| code: 'ERR_SQLITE_ERROR', | ||
| errcode: 1, | ||
| errstr: 'no such table: does_not_exist', |
There was a problem hiding this comment.
Wrong way around I think, see other comment.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60227 +/- ##
==========================================
- Coverage 88.56% 88.56% -0.01%
==========================================
Files 704 704
Lines 208125 208160 +35
Branches 40003 40013 +10
==========================================
+ Hits 184332 184361 +29
- Misses 15809 15812 +3
- Partials 7984 7987 +3
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #60198
I added report content for SQLTagStore.
Although the text in errstr differs from that of a conventional prepared statement, it now matches the corresponding SQLite function name.