v8: add heap profile API #60231
Open
v8: add heap profile API #60231
+179
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
theanarkh
force-pushed
the
add_v8_heap_profile
branch
from
70788c9 to
9024efa
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60231 +/- ##
=======================================
Coverage 88.56% 88.57%
=======================================
Files 704 704
Lines 208125 208176 +51
Branches 40003 40019 +16
=======================================
+ Hits 184332 184386 +54
- Misses 15809 15822 +13
+ Partials 7984 7968 -16
🚀 New features to boost your workflow:
|
IlyasShabi
reviewed
Oct 13, 2025
| @@ -279,6 +279,30 @@ void StopCpuProfile(const FunctionCallbackInfo<Value>& args) { | |||
| } | |||
| } | |||
|
|
|||
| void StartHeapProfile(const FunctionCallbackInfo<Value>& args) { | |||
| Isolate* isolate = args.GetIsolate(); | |||
| if (isolate->GetHeapProfiler()->StartSamplingHeapProfiler()) { | |||
There was a problem hiding this comment.
StartSamplingHeapProfiler returns false if a sampling heap profiler is already running, we should check the value if false we stop this operation.
https://v8docs.nodesource.com/node-6.17/d7/d76/classv8_1_1_heap_profiler.html#ada00bb7ec0b7827ce97280a1fb6e1f64
There was a problem hiding this comment.
Thanks for reviewing ! An Error will be thrown in the following code when false is returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #59807
make -j4 test(UNIX), orvcbuild test(Windows) passes