quic: For streams allow ReadableStream as body #60237
Open
+463
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
@jasnell This try to add support for streams for outgoing data. I hope the PR is helpful and does not waste too much time. I have contributed long time ago 1-2 patches, but I am not that fluent with the node.js codebase. |
After the change the body parameter for all created QuicStreams can take a ReadableStream of Uint8Array, Arraybuffers etc.. We introduce a DataQueueFeeder class, that may be also used for other related mechanisms. A locally created unidirectional Stream can not have a reader. Therefore the interface is changed to handle this case. (undercovered when writing the tests). Furthermore, a ResumeStream must be added After AddStream in QuicSession, as the ResumeStream beforehand triggered with set_outbound is a no-op, as Stream was not added to Session beforehand. Fixes: nodejs#60234
martenrichter
force-pushed
the
quicbodyasreadable
branch
from
10ccd9f to
d31f2c8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60237 +/- ##
==========================================
+ Coverage 88.54% 88.75% +0.21%
==========================================
Files 704 704
Lines 208123 208314 +191
Branches 40006 40073 +67
==========================================
+ Hits 184280 184890 +610
+ Misses 15877 15350 -527
- Partials 7966 8074 +108
🚀 New features to boost your workflow:
|
|
There is a crash on some platforms. TODO for next weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the change the body parameter for all
created QuicStreams can take a ReadableStream
of Uint8Array, Arraybuffers etc..
We introduce a DataQueueFeeder class that may be
also used for other related mechanisms.
A locally created unidirectional Stream can not
have a reader. Therefore, the interface is changed
to handle this case. (undercovered when writing
the tests).
Furthermore, a ResumeStream must be added after
AddStream in QuicSession, as the ResumeStream
beforehand triggered with set_outbound is a no-op,
as Stream was not added to Session beforehand.
Fixes: #60234