src: use Utf8Value and TwoByteValue instead of V8 helpers
#60244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our own helper classes have the advantage of using stack storage a lot of the time, so they should always be preferred.
We should be using our own helpers for this instead.
|
Review requested:
|
nodejs-github-bot
added
c++
addaleax
added
the
commit-queue-rebase
legendecas
reviewed
Oct 13, 2025
legendecas
approved these changes
Oct 13, 2025
RafaelGSS
approved these changes
Oct 13, 2025
geeksilva97
approved these changes
Oct 13, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60244 +/- ##
==========================================
- Coverage 88.56% 88.55% -0.02%
==========================================
Files 704 704
Lines 208123 208152 +29
Branches 40014 40011 -3
==========================================
- Hits 184330 184319 -11
- Misses 15815 15861 +46
+ Partials 7978 7972 -6
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Oct 13, 2025
IlyasShabi
approved these changes
Oct 13, 2025
vmoroz
reviewed
Oct 13, 2025
| Local<String> type = | ||
| String::NewFromUtf8(isolate, name, NewStringType::kInternalized) | ||
| .ToLocalChecked(); | ||
| Local<String> type = ToV8Value(isolate->GetCurrentContext(), name, isolate) |
There was a problem hiding this comment.
Technically, this new code behaves a bit differently from the old one: it creates a normal string, while before it used to created an internalized string.
Should we add ToV8InternalizedString utility function? Or add optional string type parameter to ToV8Value. Otherwise, we can keep it here as
String::NewFromUtf8(isolate, name.data(), NewStringType::kInternalized, name.size())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src: use
Utf8ValueandTwoByteValueinstead of V8 helpersOur own helper classes have the advantage of using stack storage
a lot of the time, so they should always be preferred.
tools: add C++ lint rule to avoid using
String::Utf8ValueWe should be using our own helpers for this instead.