-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
sqlite: make SQLTagStore.prototype.size
a getter
#60246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but all of the stylistic changes should really be made separately.
dabca78
to
3142319
Compare
I'm already half-addressing them de facto with the main change, but these can be spun out if desired. Edit: Spun out the other doc changes. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60246 +/- ##
==========================================
- Coverage 88.56% 88.55% -0.02%
==========================================
Files 704 704
Lines 208146 208155 +9
Branches 40009 40027 +18
==========================================
- Hits 184354 184338 -16
- Misses 15814 15824 +10
- Partials 7978 7993 +15
🚀 New features to boost your workflow:
|
3142319
to
ff66727
Compare
Drive-by: make callback `args` parameter names consistent
ff66727
to
a2eaaa0
Compare
As implemented,
.db
and.capacity
are getters, and.size
is a callable method. There's no reason for this inconsistency, so change.size
to a getter.Drive-by changes while making alterations to the class template:
FunctionCallbackInfo
parameter for SQLTagStore member functions was variably labelledargs
orinfo
, and wasn't consistent with the header either. Use the canonicalargs
.