-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
test: skip sea tests on x64 macOS #60250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This makes skipping/running these tests easier to manage with a dedicated test runner that can be tweaked for SEA.
It's unlikely that anyone would invest in fixing them on x64 macOS in the near future, now that x64 macOS is being phased out. Simply skip them for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also migrate
node/test/sequential/sequential.status
Lines 74 to 93 in 59b70e5
[$system==linux && $arch==ppc64] | |
# https://github.com/nodejs/node/issues/59561 | |
test-single-executable-application: SKIP | |
test-single-executable-application-assets: SKIP | |
test-single-executable-application-assets-raw: SKIP | |
test-single-executable-application-asset-keys-empty: SKIP | |
test-single-executable-application-asset-keys: SKIP | |
test-single-executable-application-disable-experimental-sea-warning: SKIP | |
test-single-executable-application-empty: SKIP | |
test-single-executable-application-exec-argv: SKIP | |
test-single-executable-application-exec-argv-empty: SKIP | |
test-single-executable-application-exec-argv-extension-cli: SKIP | |
test-single-executable-application-exec-argv-extension-env: SKIP | |
test-single-executable-application-exec-argv-extension-none: SKIP | |
test-single-executable-application-inspect-in-sea-flags: SKIP | |
test-single-executable-application-inspect: SKIP | |
test-single-executable-application-snapshot: SKIP | |
test-single-executable-application-snapshot-and-code-cache: SKIP | |
test-single-executable-application-snapshot-worker: SKIP | |
test-single-executable-application-use-code-cache: SKIP |
sequential.status
to the new sea.status
?
|
||
[$system==macos && $arch==x64] | ||
# https://github.com/nodejs/node/issues/59553 | ||
test-single-executable-application*: SKIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this syntax will work. Guess we can run the CI to check.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60250 +/- ##
==========================================
+ Coverage 88.53% 88.56% +0.02%
==========================================
Files 704 704
Lines 208087 208156 +69
Branches 40010 40012 +2
==========================================
+ Hits 184239 184361 +122
+ Misses 15866 15823 -43
+ Partials 7982 7972 -10 🚀 New features to boost your workflow:
|
test: move sea tests into test/sea
This makes skipping/running these tests easier to manage with a
dedicated test runner that can be tweaked for SEA.
test: skip sea tests on x64 macOS
It's unlikely that anyone would invest in fixing them on x64 macOS in the
near future, now that x64 macOS is being phased out. Simply skip them
for now.
Refs: #59553