Skip to content

build: add temporal to linux GHA build #60942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
legendecas wants to merge 3 commits into from
Closed

build: add temporal to linux GHA build #60942

legendecas wants to merge 3 commits into from

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Dec 3, 2025 •
edited
Loading

Ensure that the V8 temporal build is good. GitHub Action is easier to install rust toolchains, so we can start with GHA to test temporal builds.

This includes builds on ubuntu x64 and arm64.

Use rustc v1.82.0 as https://doc.rust-lang.org/beta/releases.html#version-1820-2024-10-17 noted that this is the oldest version support of llvm v19.

Refs: #60897
Refs: #58730

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 3, 2025 •
edited by legendecas
Loading

Review requested:

  • @nodejs/actions
  • @nodejs/build

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 3, 2025
@legendecas legendecas marked this pull request as ready for review December 3, 2025 11:13
@legendecas legendecas marked this pull request as draft December 3, 2025 11:13
@legendecas legendecas marked this pull request as ready for review December 3, 2025 13:52
@legendecas legendecas force-pushed the temporal-ci-pr branch 2 times, most recently from be7436f to 2544f16 Compare December 3, 2025 14:11
@legendecas legendecas added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Dec 3, 2025
aduh95
aduh95 reviewed Dec 3, 2025
View reviewed changes
@aduh95
Copy link
Contributor

aduh95 commented Dec 3, 2025

Shouldn't we add dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. as well?

@legendecas
Copy link
Member Author

legendecas commented Dec 3, 2025 •
edited
Loading

Shouldn't we add dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. as well?

temporal_capi is already in the V8 of v25.x branch: https://github.com/nodejs/node/blob/v25.x/deps/v8/BUILD.gn#L2326

node/deps/v8/BUILD.gn

Line 2326 in fc996fd

public_deps = [ "//third_party/rust/temporal_capi" ]

And #60703 didn't mark with dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. .

So this should be able to land on v25.x

@legendecas legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 4, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 5, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 5, 2025

Landed in e776946...253b16f

nodejs-github-bot pushed a commit that referenced this pull request Dec 5, 2025
@legendecas @nodejs-github-bot
build: add temporal to linux GHA build
a004535 
PR-URL: #60942
Refs: #60897
Refs: #58730
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Dec 5, 2025
@legendecas @nodejs-github-bot
doc: add note about rust toolchain version requirement
253b16f 
PR-URL: #60942
Refs: #60897
Refs: #58730
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@legendecas legendecas deleted the temporal-ci-pr branch December 5, 2025 11:44
targos pushed a commit that referenced this pull request Dec 5, 2025
@legendecas @targos
build: add temporal to linux GHA build
e839eed 
PR-URL: #60942
Refs: #60897
Refs: #58730
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Dec 5, 2025
@legendecas @targos
doc: add note about rust toolchain version requirement
fad74a8 
PR-URL: #60942
Refs: #60897
Refs: #58730
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos
Copy link
Member

targos commented Dec 5, 2025

I pushed v25.x-staging with this commit today and it failed: https://github.com/nodejs/node/actions/runs/19964374188/job/57252255440

@targos targos added the backport-requested-v25.x PRs awaiting manual backport to the v25.x-staging branch. label Dec 5, 2025
@legendecas
Copy link
Member Author

legendecas commented Dec 5, 2025

I pushed v25.x-staging with this commit today and it failed: https://github.com/nodejs/node/actions/runs/19964374188/job/57252255440

Ah so temporal v0.1.0 requires https://chromium-review.googlesource.com/c/v8/v8/+/6944922, and it depends on #60111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v25.x PRs awaiting manual backport to the v25.x-staging branch. build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@legendecas @nodejs-github-bot @aduh95 @targos @cjihrig