Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use @node-core #36

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Oct 7, 2024

#21

  • add @node-core npm scope

@richardlau
Copy link
Member

  • add workflow to publish package using npm provenance.

We already have a release workflow in .github/workflows/test-and-release.yml using semantic-release (which also looks to support npm provenance).

@AugustinMauroy
Copy link
Member Author

  • add workflow to publish package using npm provenance.

We already have a release workflow in .github/workflows/test-and-release.yml using semantic-release (which also looks to support npm provenance).

Ok I'll read that I'm not 100% aware on this tool. Thanks for mentioning that

@AugustinMauroy
Copy link
Member Author

@richardlau DONE !

@AugustinMauroy
Copy link
Member Author

any news ?

@rvagg
Copy link
Member

rvagg commented Nov 15, 2024

I think this repo might have an npm api key for me in it, so a new one might need to be inserted to publish to this new scope as I don't think I have access to it.

@rvagg
Copy link
Member

rvagg commented Nov 15, 2024

also, a package.json conflict needs to be resolved

@AugustinMauroy
Copy link
Member Author

@rvagg any news ? (I know I have to fix conflict again)

@rvagg
Copy link
Member

rvagg commented Feb 25, 2025

🤷 I don't care too much but this would have to be plumbed through to the server that uses it. I also don't know if I have access to publish to that scope, the auto-publish workflow might break on this so in terms of friction I wouldn't bother but it depends on who's pushing for it and how much effort they want to go to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants