Skip to content

Added Romanian locale #6496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 24, 2024
Merged

Added Romanian locale #6496

merged 4 commits into from
Mar 24, 2024

Conversation

vladutilie
Copy link
Contributor

Hello!

Description

I have added the locale config files for Romanian.

Validation

The added locale config should be checked.

Related Issues

N/A

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Regards,
Vlad

@vladutilie vladutilie requested a review from a team as a code owner March 20, 2024 11:43
@vercel Vercel
Copy link

vercel bot commented Mar 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 24, 2024 0:28am

@AugustinMauroy AugustinMauroy added the i18n Issues/PRs related to the Website Internationalisation label Mar 24, 2024
ovflowd
ovflowd reviewed Mar 24, 2024
View reviewed changes
ovflowd
ovflowd approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 24, 2024
@ovflowd ovflowd enabled auto-merge March 24, 2024 12:26
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 24, 2024
@ovflowd
Update config.json
81ff053 
Signed-off-by: Claudio W <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 24, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 90 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 91 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 90 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟠 89 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 90 🟢 100 🟢 92 🔗

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 24, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 24, 2024 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 84%
 80.07% (450/562) 79.55% (144/181) 71.17% (79/111)

Unit Test Report

Tests Skipped Failures Errors Time
90 0 💤 0 ❌ 0 🔥 4.519s ⏱️

@ovflowd ovflowd added this pull request to the merge queue Mar 24, 2024
Merged via the queue into nodejs:main with commit 5b1a093 Mar 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd approved these changes

Assignees
No one assigned
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladutilie @ovflowd @AugustinMauroy