fix: Disable text selection for <Select> options #6525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Contributor
Unit Test Coverage Report
Unit Test Report
|
AugustinMauroy
approved these changes
Mar 24, 2024
Member
AugustinMauroy
left a comment
AugustinMauroy
left a comment
There was a problem hiding this comment.
LGTM ! Thanks for your first contribution 🎉
mikeesto
approved these changes
Mar 25, 2024
aymen94
approved these changes
Mar 25, 2024
ovflowd
approved these changes
Mar 25, 2024
Member
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
That is a nice little fix and extremely appreciated :)
Member
|
I'm fast-tracking this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a strange behavior in Firefox when you try to pick a Node.js version from the select component on the Downloads page. Once you click on an option it also starts a text selection mode which you can see in the video below:
beforeselect.mov
This PR fixes it by disabling text selection for the options inside the
<Select>component.Validation
selectafter.mov
Related Issues
Check List
npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.npx turbo buildto check if the website builds without errors.