Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit artist for Rocket Turtle branding #7088

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

TheFossilDev
Copy link
Contributor

@TheFossilDev TheFossilDev commented Oct 4, 2024

Description

Adds credit to the original Artist who designed the Rocket Turtle mascot via twitter link and handle. I am new, let me know if translation is needed. I am happy to add whatever is necessary.

Validation

Reviewers should see that the credit text is now visible below the Rocket Turtle image itself at /en/about/branding#nodejs-mascot

Related Issues

Addresses #7083

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@TheFossilDev TheFossilDev requested a review from a team as a code owner October 4, 2024 18:56
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 5, 2024 6:43pm

@TheFossilDev TheFossilDev changed the title Feat: Credit artist for Rocket Turtle branding #7083 Credit artist for Rocket Turtle branding Oct 4, 2024
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for your contribution

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 6, 2024
@ovflowd ovflowd enabled auto-merge October 6, 2024 19:36
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 6, 2024
Copy link
Contributor

github-actions bot commented Oct 6, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 96 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Oct 6, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.47% (589/651) 76.29% (177/232) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.361s ⏱️

@TheFossilDev
Copy link
Contributor Author

Local build was good for me. Anything I need to do?

@AugustinMauroy
Copy link
Member

@TheFossilDev normally it's ok

@ovflowd ovflowd disabled auto-merge October 6, 2024 20:11
@ovflowd ovflowd merged commit b14bea1 into nodejs:main Oct 6, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants