Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added volta to package manager download dropdown #7497

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

benhalverson
Copy link
Member

@benhalverson benhalverson commented Feb 15, 2025

Description

This PR adds Volta to the download dropdown selection

Related Issues

Fix #6832

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Feb 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Feb 18, 2025 4:28am

Copy link
Contributor

github-actions bot commented Feb 15, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟠 89 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Feb 15, 2025

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
88.75% (742/836) 76.1% (242/318) 87.65% (142/162)

Unit Test Report

Tests Skipped Failures Errors Time
182 0 💤 0 ❌ 0 🔥 5.782s ⏱️

@AugustinMauroy
Copy link
Member

Could you add stories on https://github.com/nodejs/nodejs.org/blob/e10c6af1dc108152212c9f9f33029a1d6efc76ac/apps/site/components/__design__/platform-logos.stories.tsx

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Feb 18, 2025
@ovflowd ovflowd enabled auto-merge February 18, 2025 16:24
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 18, 2025
@ovflowd ovflowd added this pull request to the merge queue Feb 18, 2025
Merged via the queue into nodejs:main with commit 0b2e7b6 Feb 18, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding volta in download/package-manager
5 participants