-
Notifications
You must be signed in to change notification settings - Fork 6.3k
meta: redirect Corepack documentation page #7643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- apps/site/redirects.json: Language not supported
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The website doesn't serve /api
or /docs
, so these redirects wouldn't be functional. These would either need to be set up in Cloudflare or in the release worker
@flakey5 if you open an issue/pr on right repo we can close this one |
I think we shouldn't introduce the redirect till Corepack is removed from Node.js latest, which will happen in 25.0.0 in October 2025. I've called it out in #7643 (comment) |
Antoine and I discussed over OpenJS Slack channel #nodejs-corepack
and realized that it should be okay to add redirect for corepack latest after 24.0.0 launch since:
- Only the way corepack is distributed is changing. The branding and functionality remains the same.
- The decision to remove corepack was taken before v24.0.0. The redirect can be considered as semver-major.
The next action is to setup redirect in Cloudflare or in the release worker, and close this PR. |
I'm closing this PR since, no matter what happens, this cannot merge in this repository, however, feel free to continue discussing the future in this PR, if needed. |
Also, for posterity, @trivikr was referencing https://openjs-foundation.slack.com/archives/C06LTLUK9NZ/p1744489893809369 |
Description
To address nodejs/node#57663 (comment).
This page is being removed, however it's quite cheap for us not to break the existing links.
Validation
Related Issues
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.