Skip to content

meta: redirect Corepack documentation page #7643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 11, 2025

Description

To address nodejs/node#57663 (comment).

This page is being removed, however it's quite cheap for us not to break the existing links.

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Copilot Copilot bot review requested due to automatic review settings April 11, 2025 17:17
@aduh95 aduh95 requested a review from a team as a code owner April 11, 2025 17:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • apps/site/redirects.json: Language not supported

Copy link

vercel bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 11, 2025 5:18pm

Copy link
Member

@flakey5 flakey5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The website doesn't serve /api or /docs, so these redirects wouldn't be functional. These would either need to be set up in Cloudflare or in the release worker

@AugustinMauroy
Copy link
Member

@flakey5 if you open an issue/pr on right repo we can close this one

@trivikr
Copy link
Member

trivikr commented Apr 11, 2025

if you open an issue/pr on right repo we can close this one

I think we shouldn't introduce the redirect till Corepack is removed from Node.js latest, which will happen in 25.0.0 in October 2025.

I've called it out in #7643 (comment)

@trivikr trivikr self-requested a review April 14, 2025 01:54
@trivikr trivikr dismissed their stale review April 14, 2025 01:57

Antoine and I discussed over OpenJS Slack channel #nodejs-corepack and realized that it should be okay to add redirect for corepack latest after 24.0.0 launch since:

  • Only the way corepack is distributed is changing. The branding and functionality remains the same.
  • The decision to remove corepack was taken before v24.0.0. The redirect can be considered as semver-major.
@trivikr
Copy link
Member

trivikr commented Apr 14, 2025

These would either need to be set up in Cloudflare or in the release worker

The next action is to setup redirect in Cloudflare or in the release worker, and close this PR.

@avivkeller
Copy link
Member

I'm closing this PR since, no matter what happens, this cannot merge in this repository, however, feel free to continue discussing the future in this PR, if needed.

@avivkeller avivkeller closed this Apr 14, 2025
@avivkeller
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants