Add CI check for Cloudflare Worker build #7743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a CI check to verify the Cloudflare Worker build by leveraging turborepo’s dependsOn configurations and by removing legacy pre-scripts. It also introduces a new GitHub Actions workflow dedicated to the Cloudflare OpenNext build.
- Removed prebuild and predev scripts in package.json in favor of turborepo configuration.
- Added new Cloudflare build, preview, and deploy tasks in turbo.json.
- Introduced a dedicated GitHub Actions workflow (.github/workflows/cloudflare-open-next-build.yml) to verify the Cloudflare Worker build.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/site/turbo.json | Updated turborepo tasks with new dependency configurations. |
| apps/site/package.json | Removed legacy pre-scripts and adjusted Cloudflare commands. |
| .github/workflows/cloudflare-open-next-build.yml | Added new workflow for Cloudflare Worker build validation. |
Comments suppressed due to low confidence (2)
apps/site/package.json:24
- The updated preview script no longer invokes the Cloudflare worker build process, which may affect local preview workflows. Please verify that this change is intentional if local development should not trigger the build.
"cloudflare:preview": "wrangler dev"
apps/site/package.json:25
- The deploy script now directly calls 'wrangler deploy' without a preceding build step, which might lead to deployment of outdated code if the build is not run separately. Confirm that this behavior aligns with the intended deployment workflow.
"cloudflare:deploy": "wrangler deploy"
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7743 +/- ##
==========================================
+ Coverage 74.85% 74.87% +0.01%
==========================================
Files 98 98
Lines 7895 7895
Branches 200 200
==========================================
+ Hits 5910 5911 +1
+ Misses 1984 1983 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
avivkeller
reviewed
May 13, 2025
avivkeller
reviewed
May 13, 2025
… pushes remove windows since the OpenNext adapter is not compatible with it
avivkeller
reviewed
May 13, 2025
…o `dependsOn` configs add back `prebuild` script as that is needed for the vercel deployment
… pushes Apply suggestions from code review Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Dario Piotrowicz <[email protected]>
… pushes remove unnecessary filter
… pushes update incorrect `pull_request_target` to `pull_request`
avivkeller
approved these changes
May 13, 2025
flakey5
approved these changes
May 13, 2025
avivkeller
reviewed
May 13, 2025
avivkeller
reviewed
May 13, 2025
avivkeller
reviewed
May 13, 2025
github-actions
bot
removed
the
github_actions:pull-request
|
OpenNext CI run: https://github.com/nodejs/nodejs.org/actions/runs/15002557692/job/42153040053?pr=7743 (In the future, it won't need the label |
|
Lighthouse Results
|
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Dario Piotrowicz <[email protected]>
bjohansebas
approved these changes
May 14, 2025
aymen94
approved these changes
May 14, 2025
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As suggested by @avivkeller I'm adding a CI check to make sure that the Cloudflare OpenNext adapter build succeeds on PRs/pushes to main.
As part of this I am removing the pre scripts I had before in favour of turborepo
dependsOnconfigs (I am not super familiar with turborepo but I thing/guess thatdependsOnconfigs should be preferred and replace pre scripts? 🤔)Note
This is a temporary CI check (that's also one of the reasons why I created a new, very easy to delete, workflow file for it instead of adding this to the build workflow) that can help us get some confidence in the OpenNext Cloudflare adapter and in the fact that the adapter doesn't effect DX.
However I think that this will become obsolete/unnecessary as soon as we have some e2e tests that also validate the OpenNext build.
Validation
I've validated this workflow in my nodejs.org fork see action run.
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.