Skip to content

src: simplify router, add cache middleware tests #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2025
Merged

src: simplify router, add cache middleware tests #713

merged 2 commits into from
Oct 22, 2025

Conversation

@flakey5
Copy link
Member

@flakey5 flakey5 commented Oct 11, 2025

  • We don't need to be making the middleware chain ourselves, itty router can take care of it for us.
    • We do still need to add some error handling to keep some of the intended behavior for middleware though
  • Better tests for the router
  • Tests for the cache middleware

@flakey5 flakey5 requested a review from a team as a code owner October 11, 2025 22:37
flakey5
flakey5 commented Oct 20, 2025
View reviewed changes
@flakey5 flakey5 merged commit f762a7a into main Oct 22, 2025
5 checks passed
@flakey5 flakey5 deleted the flakey5/20251011/routing branch October 22, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

+1 more reviewer

@avivkeller avivkeller avivkeller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flakey5 @MattIPv4 @avivkeller