Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add docker-team as resource #1426

Merged
merged 4 commits into from
Jan 30, 2025
Merged

doc: add docker-team as resource #1426

merged 4 commits into from
Jan 30, 2025

Conversation

RafaelGSS
Copy link
Member

No description provided.

RafaelGSS
RafaelGSS commented Jan 16, 2025
View reviewed changes
Copy link
Member Author

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nodejs/docker could you please review it?

SimenB
SimenB reviewed Jan 16, 2025
View reviewed changes
MAINTAINERS_THREAT_MODEL.md Outdated Show resolved Hide resolved
SimenB
SimenB approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beyond one question, seems correct to my untrained eyes 👍

@RafaelGSS
Copy link
Member Author

PTAL @richardlau

@RafaelGSS RafaelGSS requested a review from richardlau January 27, 2025 20:46
mhdawson
mhdawson approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS RafaelGSS merged commit b6ac043 into main Jan 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB SimenB approved these changes

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau Awaiting requested review from richardlau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RafaelGSS @SimenB @richardlau @mhdawson