don't check AbortSignal maxListeners on some node versions #4045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhafraDev
commented
Feb 3, 2025
| try { | ||
| abortSignalHasEventHandlerLeakWarning = getMaxListeners(new AbortController().signal) > 0 | ||
| } catch { | ||
| abortSignalHasEventHandlerLeakWarning = false |
There was a problem hiding this comment.
getMaxListeners throws with 0 signals (nodejs/node@752c0b8)
Comment on lines
-427
to
-428
| // Third-party AbortControllers may not work with these. | ||
| // See, https://github.com/nodejs/undici/pull/1910#issuecomment-1464495619. |
There was a problem hiding this comment.
we don't support third party AbortControllers anymore
metcoder95
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #4032