fix: ac lost on cloned request (#4068) #4678
Open
+80
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #4068
Changes
This PR fixes an issue where cloning a
Requestcaused the cloned instance to lose itsAbortSignalbehavior under certain GC conditions.The underlying problem was that the
signalreference could be garbage-collected prematurely, preventing the abort event from propagating to the cloned request. This resulted in inconsistent abort behavior on the very first request processed after a clone.The fix ensures the
signaland its abort listener remain properly retained across clones, restoring consistent abort propagation for clonedRequestobjects.Bug Fixes
Request.clone()ornew Request(request), could drop the associatedAbortSignallistener during garbage collection.Requestobjects consistently propagate abort events, including during the initial request lifecycle.Status