Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZMS-101 #553

Merged
merged 34 commits into from
Nov 30, 2023
Merged

ZMS-101 #553

merged 34 commits into from
Nov 30, 2023

Conversation

NickOvt
Copy link
Contributor

@NickOvt NickOvt commented Nov 10, 2023

  1. Description now stays where it was defined, that is if using the same component the fields will still have the same component, but different descriptions
  2. Added missing descriptions for the fields in the schemas in the messages-schemas.js file

…one route in mailboxes.js and messages.js files so that the api docs generation can be done at all
… file. messages-schemas.js used for messages endpoint schemas
… response object there. Add response object parsing functionality to api.js
@NickOvt NickOvt changed the base branch from ZMS-87 to master November 10, 2023 09:08
@NickOvt NickOvt changed the title Zms 101 ZMS-101 Nov 10, 2023
@NickOvt NickOvt requested a review from andris9 November 10, 2023 09:24
Copy link
Member

@andris9 andris9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andris9
Copy link
Member

andris9 commented Nov 10, 2023

Conflicts with previous PR. Can not merge.

@andris9 andris9 merged commit 3c9e175 into master Nov 30, 2023
@andris9 andris9 deleted the ZMS-101 branch November 30, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants