You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to reduce the amount of call to JSON.parse in order to improve the idle CPU performance of wildduck when a lot of connections are open. Also reduce the amount of empty emits by listeners
based on testing (4500 requests each for creating a message (has no payload) and logging out (has payload))
Performance has improved 2x-3x fold in case of no payload that is only .e and no parsing is needed.
Performance is the same or 100ns faster in case when data has the payload.
based on testing (4500 requests each for creating a message (has no payload) and logging out (has payload)) Performance has improved 2x-3x fold in case of no payload that is only .e and no parsing is needed. Performance is the same or 100ns faster in case when data has the payload.
The no-payload version happens way more, as it is triggered any time something happens on the email account, e.g. an email is marked as seen or unseen. So if this use case gets optimized it is a great win 🏆
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to reduce the amount of call to JSON.parse in order to improve the idle CPU performance of wildduck when a lot of connections are open. Also reduce the amount of empty emits by listeners