-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Espressif SDK v2.2.1 #2401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Espressif SDK v2.2.1 #2401
Conversation
Minimally build and boot tested, but the changes look pretty boring. Fixes nodemcu#2395
|
Looks good. Espressif missed to update |
|
Bah humbug re: Espressif. We could leave it be or change with or just bump |
In light of the discussions in #2398 I don't think we should. P.S. -> espressif/ESP8266_NONOS_SDK#136 |
|
@marcelstoer How do you feel about calling this 2.2.0.1 while we wait on Espressif? |
|
@nwf I wouldn't do that. If Espressif fixes this we'd be shipping essentially the same SDK as before and, therefore, an change from 2.2.0.1 to 2.2.1.0 would feel odd to me. |
|
Why don't we simply wait on SDK 2.2.1 until Espressif releases a fix? |
|
SDK 2.2.1 is already released, that's what this PR is about. See my comment further up. |
|
@marcelstoer Admittedly, I was imagining we'd wait until 2.2.2 or 2.3.0 or 3.0.0 or whatever to re-merge with upstream, so we'd not do a 2.2.0.1 to 2.2.1.0 transition. I'm content to wait a bit to see what Espressif does. |
They haven't even commented on my PR in a month... |
Minimally build and boot tested, but the changes look pretty boring.
Fixes #2395
devbranch rather than formaster.