Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jinja2cpp: update submodule for partial subscript crash fix #3394

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

cebtenzzre
Copy link
Member

@cebtenzzre cebtenzzre commented Jan 17, 2025

This fixes the crash when you enter this text in the chat template field:

{{ a["foo"(

The crash was caused by this assertion failure:

nonstd/expected.hpp:2173: nonstd::expected_lite::expected<T, E>::value_type& nonstd::expected_lite::expected<T, E>::operator*() & [with T = std::shared_ptr<jinja2::ExpressionEvaluatorBase>; E = jinja2::ParseError; value_type = std::shared_ptr<jinja2::ExpressionEvaluatorBase>]: Assertion `has_value()' failed.`

@cebtenzzre cebtenzzre marked this pull request as ready for review January 17, 2025 22:31
@cebtenzzre cebtenzzre requested a review from manyoso January 17, 2025 22:31
@manyoso manyoso merged commit 68047d9 into main Jan 21, 2025
3 of 4 checks passed
cgivre pushed a commit to cgivre/gpt4all that referenced this pull request Feb 4, 2025
@cebtenzzre cebtenzzre deleted the fix-jinja2cpp-crash-2 branch February 10, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants