Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jinja2cpp: update submodule to fix unused var #3403

Merged
merged 1 commit into from
Jan 22, 2025
Merged

jinja2cpp: update submodule to fix unused var #3403

merged 1 commit into from
Jan 22, 2025
+1 −1

Conversation

cebtenzzre
Copy link
Member

As an unexpected consequence of #3402, CI is catching a new fatal warning:

In file included from /Users/distiller/project/gpt4all-chat/deps/Jinja2Cpp/src/expression_parser.cpp:1:
/Users/distiller/project/gpt4all-chat/deps/Jinja2Cpp/src/expression_parser.h:44:23: error: private field 'm_topLevelRenderer' is not used [-Werror,-Wunused-private-field]
    ComposedRenderer* m_topLevelRenderer = nullptr;
                      ^
1 error generated.

This PR fixes that. Confirmed working locally on macOS.

@cebtenzzre cebtenzzre requested a review from manyoso January 21, 2025 23:00
@manyoso manyoso merged commit 3e70ae9 into main Jan 22, 2025
4 of 8 checks passed
cebtenzzre added a commit that referenced this pull request Jan 22, 2025
@cebtenzzre
jinja2cpp: update submodule to fix unused var (#3403)
0348189 
Signed-off-by: Jared Van Bortel <[email protected]>
cgivre pushed a commit to cgivre/gpt4all that referenced this pull request Feb 4, 2025
@cebtenzzre @cgivre
jinja2cpp: update submodule to fix unused var (nomic-ai#3403)
f0ebabd 
Signed-off-by: Jared Van Bortel <[email protected]>
@cebtenzzre cebtenzzre deleted the fix-jinja-unused-var branch February 10, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manyoso manyoso manyoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cebtenzzre @manyoso