Skip to content

Commit

Permalink
minore changes
Browse files Browse the repository at this point in the history
Signed-off-by: shirady <[email protected]>
  • Loading branch information
shirady committed Mar 6, 2025
1 parent 5445f62 commit 08dde38
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 11 deletions.
16 changes: 7 additions & 9 deletions src/deploy/NVA_build/AWSClient.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,25 +9,23 @@ WORKDIR /root/node_modules/noobaa-core/

RUN npm install --only=dev

##############################################################
############################################################################
# Layers:
# Title: Install go and modules fot testing with AWS SDK GO client
# Size: ~ 79 M (download size) ~ 232 M (installed size)
# This part was added to support running aws sdk go tests
##############################################################
# Title: Install go and modules
# for testing with AWS SDK GO client with most updated version

############################################################################

# installing go
RUN dnf install -y golang
# verify installation
# verify go installation
RUN go version
# set the PATH for go
ENV PATH="/usr/local/go/bin:$PATH"

# install the needed modules
# note: the files go.mod and go.sum will be automatically created after this step in the WORKDIR
RUN go mod init src/test/unit_tests/different_clients
RUN go mod tidy
# copy the files
# COPY go.mod /root/node_modules/noobaa-core
# COPY go.sum /root/node_modules/noobaa-core

USER 10001:0
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ mocha.describe('Go AWS SDK V2 Client script execution', function() {
const bucket_name = 'lala-bucket';
const key_name = 'test-key';
const mpu_key_name = 'test-mpu-key';
// const endpoint = 'https://localhost:12443';
const endpoint = coretest.get_http_address();
console.log('test_go_sdkv2_script: endpoint', endpoint);

Expand All @@ -47,7 +46,7 @@ mocha.describe('Go AWS SDK V2 Client script execution', function() {
assert.equal(number_of_failing_tests, 0);
} catch (err) {
console.log('while execution of aws go client had the err', err);
assert.fail(`aws go client failed ${err}, ${err.stack}`);
assert.fail(`test aws go client failed with: ${err}, ${err.stack}`);
}
});
});
Expand Down

0 comments on commit 08dde38

Please sign in to comment.