Backport to 5.17 #8296
Merged
Backport to 5.17 #8296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. list_config_files change function signature (remove unused config_path) and edit JSDoc (add missing type) 2. rename the option from should_decrypt to decrypt_secret_key as the destructor of options uses Signed-off-by: shirady <[email protected]> (cherry picked from commit 6268072)
1. In list_config_files "mock" the entries array to have one entry and it is the name by the filter (for performance). 2. Exclude the action list from fetch_bucket_data and fetch_account_data. 3. Edit the account list tests to validate that we receive an array in the response. Signed-off-by: shirady <[email protected]> (cherry picked from commit cd5d80e)
Signed-off-by: nadav mizrahi <[email protected]> (cherry picked from commit 5e71305)
Signed-off-by: nadav mizrahi <[email protected]> (cherry picked from commit 4898af4)
1. Handle the case where the endpoint port was wrong - for example: - S3 port with IAM action - IAM port with S3 action Signed-off-by: shirady <[email protected]> (cherry picked from commit 5d071d4)
Signed-off-by: jackyalbo <[email protected]>
jackyalbo
force-pushed
the
jacky_bp_5.17
branch
from
834d302 to
37ada6f
Compare
Signed-off-by: jackyalbo <[email protected]> (cherry picked from commit 8c21f68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: