[MCG] Using put-bucket-policy with wrong syntax under Resource results in InternalError instead of MalformedPolicy #8783
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vh05
force-pushed
the
DFBUGS-1517
branch
4 times, most recently
from
f84f57a to
2280c6f
Compare
romayalon
reviewed
Feb 16, 2025
There was a problem hiding this comment.
Hey @vh05
- Please add unit tests
- Initializing regex in a function is unrecommended due to performance issues and it should be pre-compiled as a global variable, read more about it here - Pre-compiled regexp optimization #7110
- To me It looks like this issue can happen in every bucket policy field, can you please check if we need this fix in more places?
- @nadavMiz since you are the last one to change this area, I would appreciate your review as well.
nadavMiz
reviewed
Feb 17, 2025
| const resource_regex = RegExp(`^${resource_bucket_part.replace(qm_regex, '.?').replace(ar_regex, '.*')}$`); | ||
| const resource_regex = RegExp( | ||
| `^${resource_bucket_part | ||
| .replace(/[-/^$+?.()|[\]{}]/g, '\\$&') |
There was a problem hiding this comment.
notice that we are modifying the ? character right after your change. did you check it doesn't effect this? worth adding a test as well if one doesn't already exists
There was a problem hiding this comment.
@nadavMiz I think the question mark (?) will be replaced with \? in the 1st part then ? will be replace by \.? . Have limited or no knowledge on this. Checking this
|
…s in InternalError instead of MalformedPolicy The malformed syntax should give malformed systax error. Issue: Square brackets ([ ]) in resource_bucket_part were misinterpreted in regex. Fix: Escape all regex special characters before inserting into RegExp(). Fixes: https://issues.redhat.com/browse/DFBUGS-1517 Signed-off-by: Vinayakswami Hariharmath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The malformed syntax should give malformed systax error.
Issue: Square brackets ([ ]) in resource_bucket_part were misinterpreted in regex.
Fix: Escape all regex special characters before inserting into RegExp().
Fixes: https://issues.redhat.com/browse/DFBUGS-1517