Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ading functions to net_utils.js | nope-ip removal - Phase 4 #8787

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

liranmauda
Copy link
Contributor

Explain the changes

net_utils.js

  • Adding normalize_family that will normalize the family

  • Adding is_loopback that will check if the address is a loopback address

  • Adding is_private that will check if the address is private

  • Adding is_public that will check if the address is public

  • Adding jest tests

Copy link
Contributor

@nadavMiz nadavMiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liranmauda liranmauda force-pushed the liran-remove-node-ip-2 branch 3 times, most recently from 7a84f5b to 74be412 Compare February 26, 2025 12:31
`net_utils.js`

- Adding `normalize_family` that will normalize the family
- Adding `is_loopback` that will check if the address is a loopback address
- Adding `is_private` that will check if the address is private
- Adding `is_public` that will check if the address is public

- Adding jest tests

Signed-off-by: liranmauda <[email protected]>
@liranmauda liranmauda force-pushed the liran-remove-node-ip-2 branch from 74be412 to c8e4856 Compare February 27, 2025 06:03
@liranmauda liranmauda merged commit 6d53494 into noobaa:master Feb 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants