Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | CLI | List bucket dose not return full bucket name with .json suffix #8806

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

naveenpaul1
Copy link
Contributor

Explain the changes

  1. remove suffix remove code from add_config_file_suffix()

Issues: Fixed #xxx / Gap #xxx

  1. bucket name create with extn (.json) , noobaa cli doesn't list the bucket name completely #8802

Testing Instructions:

  1. check issue bucket name create with extn (.json) , noobaa cli doesn't list the bucket name completely #8802
  • Doc added/updated
  • Tests added

@naveenpaul1 naveenpaul1 changed the title NC | List bucket do not return full bucket name with .json suffix NC | CLI | List bucket do not return full bucket name with .json suffix Feb 18, 2025
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

@naveenpaul1 naveenpaul1 changed the title NC | CLI | List bucket do not return full bucket name with .json suffix NC | CLI | List bucket dose not return full bucket name with .json suffix Feb 24, 2025
@romayalon
Copy link
Contributor

After fixing this issue we might want to backport it to old versions
CC: @nimrod-becker

@rkomandu
Copy link
Collaborator

rkomandu commented Mar 3, 2025

@romayalon , w/r/t documentation, are you saying, either we should allow the bucket-name/account-name to have the .json as the suffix. We shouldn't touch via upgrade path, as it would get us into unknown issues. Are we trying to block the creation of bucket-name/account-name or just create and rework the listing ?

@romayalon
Copy link
Contributor

romayalon commented Mar 3, 2025

@rkomandu

  1. We don't want to block buckets/accounts that end with .json / .symlink because blocking it will make us incompatible with S3.
  2. Naveen will fix it for new buckets/accounts
  3. Naveen will document the known issue of buckets/accounts with these suffixes when created on older versions and will document a workaround.

@naveenpaul1 naveenpaul1 requested a review from romayalon March 4, 2025 11:24
@naveenpaul1 naveenpaul1 merged commit c62b217 into noobaa:master Mar 4, 2025
11 checks passed
@rkomandu
Copy link
Collaborator

rkomandu commented Mar 5, 2025

@naveenpaul1 @romayalon , are you going to backport this into any 5.18.z stream ? or leave it as is for now

@romayalon
Copy link
Contributor

@rkomandu yes, we aim to backport it to 5.18.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bucket name create with extn (.json) , noobaa cli doesn't list the bucket name completely
4 participants