NSFS | Fix delete last object deletes directory object if its size is 0 #8808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romayalon
force-pushed
the
romy-delete-last-object-dir-obj-size-0
branch
from
60c4dde to
e4628ce
Compare
nadavMiz
reviewed
Feb 19, 2025
shirady
reviewed
Feb 19, 2025
nadavMiz
reviewed
Feb 26, 2025
romayalon
force-pushed
the
romy-delete-last-object-dir-obj-size-0
branch
from
b319286 to
f6a2b5f
Compare
nadavMiz
reviewed
Mar 4, 2025
Signed-off-by: Romy <[email protected]>
romayalon
force-pushed
the
romy-delete-last-object-dir-obj-size-0
branch
from
a12fd35 to
79ed147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
sudo node node_modules/mocha/bin/mocha src/test/unit_tests/test_namespace_fs -g "delete inner object in directory object size 0 - no .folder file"