Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | close stream when getting empty content dir #8811

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

nadavMiz
Copy link
Contributor

@nadavMiz nadavMiz commented Feb 19, 2025

Explain the changes

  1. currently we don't close the write stream before returning from read_object_md for empty content dir case. this causes the client to wait for the stream to close until it times out. added closing of the stream in that case

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

manual:

  1. put empty content dir object: s3api put-object --bucket test-bucket --key key5/
  2. get the new object: 's3api get-object --bucket test-bucket --key key5 outfile`
  3. get should succeed with empty file

automatic:
sudo NC_CORETEST=true node ./node_modules/mocha/bin/mocha src/test/unit_tests/test_namespace_fs.js

  • Doc added/updated
  • Tests added

@nadavMiz nadavMiz force-pushed the content-dir-empty-get branch from b68f3e4 to 7fea51a Compare February 19, 2025 13:27
@nadavMiz nadavMiz self-assigned this Feb 19, 2025
@nadavMiz nadavMiz force-pushed the content-dir-empty-get branch 2 times, most recently from d77b20f to 716d946 Compare February 19, 2025 17:51
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
minor comments

@nadavMiz nadavMiz force-pushed the content-dir-empty-get branch 3 times, most recently from 23e1b62 to 769629d Compare February 26, 2025 16:12
@nadavMiz nadavMiz force-pushed the content-dir-empty-get branch from 769629d to 2f27896 Compare February 27, 2025 07:48
@nadavMiz nadavMiz merged commit 7681865 into noobaa:master Feb 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants