Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | whitelist cli create config.json when it doesn't exist #8813

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

nadavMiz
Copy link
Contributor

@nadavMiz nadavMiz commented Feb 19, 2025

Explain the changes

  1. when we call whitelist in cli and config.json doesn't exist we get ENOENT when trying to update the config file
  2. try to get config.json if exist update it, if it doesn't exist create it with the new data

Issues: Fixed #8775

Testing Instructions:

  1. sudo NC_CORETEST=true node ./node_modules/mocha/bin/mocha src/test/unit_tests/test_nc_cli.js
  • Doc added/updated
  • Tests added

@nadavMiz nadavMiz force-pushed the whitelist-empty-config branch from 361bb76 to 78c84b2 Compare February 19, 2025 17:23
@nadavMiz nadavMiz self-assigned this Feb 19, 2025
@nadavMiz nadavMiz force-pushed the whitelist-empty-config branch 2 times, most recently from 3304619 to fdea97e Compare February 19, 2025 18:30
@nadavMiz nadavMiz force-pushed the whitelist-empty-config branch 4 times, most recently from e7a2c0e to 6798280 Compare February 25, 2025 07:46
Copy link
Contributor

@naveenpaul1 naveenpaul1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nadavMiz nadavMiz force-pushed the whitelist-empty-config branch from 6798280 to 6f86439 Compare February 26, 2025 08:40
@nadavMiz nadavMiz merged commit bf6a967 into noobaa:master Feb 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NC | CLI | noobaa-cli whitelist command is failing when config.json was never created
2 participants