Fix RPM build on RHEL8 & friends #8843
Open
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alphaprinz This PR does compilation changes of s3_select.gyp, can you please review it? |
romayalon
reviewed
Mar 4, 2025
| @@ -4,6 +4,7 @@ | |||
| 'target_name': 's3select', | |||
| 'type': 'static_library', | |||
| 'cflags_cc!': ['-fno-rtti'], | |||
| 'cflags_cc': ['-std=c++17'], | |||
There was a problem hiding this comment.
what are the implications of this change?
There was a problem hiding this comment.
I don't think it will change anything. The reason I added it here was because I noticed that ceph/s3select use this version to build s3select - https://github.com/ceph/s3select/blob/5e7484b6b73216396f6bd6b1c8d6abca639be3e4/CMakeLists.txt#L13
tangledbytes
force-pushed
the
utkarsh/fix/rpm-build-rhel8
branch
from
54b4a78 to
f763843
Compare
Signed-off-by: Utkarsh Srivastava <[email protected]> fix rhel typo Signed-off-by: Utkarsh Srivastava <[email protected]> Fix RPM Builds for RHEL8 & friends Signed-off-by: Utkarsh Srivastava <[email protected]>
tangledbytes
force-pushed
the
utkarsh/fix/rpm-build-rhel8
branch
from
f763843 to
8ceb471
Compare
alphaprinz
reviewed
Mar 10, 2025
| @@ -32,6 +32,7 @@ RUN ./src/deploy/NVA_build/clone_s3select_submodules.sh | |||
| RUN ln -s /lib64/libboost_thread.so.1.66.0 /lib64/libboost_thread.so.1.75.0 || true | |||
| #Pass BUILD_S3SELECT down to GYP native build. | |||
| #S3Select will be built only if this parameter is equal to "1". | |||
| #Next step would fail for RHEL8 and derivates | |||
There was a problem hiding this comment.
Is this comment correct?
I thought the point is to fix RHEL8?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR attempts to fix the broken builds of NooBaa RPM on RHEL8.
Testing Instructions:
make rpm CENTOS_VER=8should work.make rpm CENTOS_VER=9should also work.