Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI | Data Buckets | Test AWS SDK Clients #8847

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Mar 3, 2025

Explain the changes

  1. Add to the CI a test that runs basic commands using the most updated AWS SDK client. In this PR it is AWS SDK Go V2 as a start.
    Note: In this PR the CI runs on push and pull_request only in the code review phase, later it will be nightly and manual only (uncomment in current file).
  2. Add log printings of 'pools_to_create.length' in coretest (helps in debugging in case the nodes/hosts were not created).

Issues:

  1. The go script and its test were described in PR Add AWS SDK Go V2 Packages and a Test Script Using It  noobaa-operator#1521 and the need for having a CI that runs with most updated SDK version was raised as a part of PR FIx Request Handling on Requests with Trailing Headers (Mainly in ChunkedContentDecoder) #8753 to help us know of major changes in the AWS client behavior.

GAP - we need to create a CI to keep the update the packages in the code - to update the go.mod and go.sum files (currently it is manual).

Testing Instructions:

  1. Run: make test-aws-sdk-clients
  • Doc added/updated
  • Tests added

@shirady shirady marked this pull request as ready for review March 3, 2025 14:52
@shirady shirady requested review from dannyzaken and jackyalbo March 3, 2025 14:52
@shirady shirady self-assigned this Mar 3, 2025
@shirady shirady requested review from liranmauda and removed request for dannyzaken March 5, 2025 07:37
shirady added 6 commits March 5, 2025 18:15
Signed-off-by: shirady <[email protected]>
Signed-off-by: shirady <[email protected]>
(cherry picked from commit 6ef0d49)
Signed-off-by: shirady <[email protected]>
(cherry picked from commit f363ed5)
Signed-off-by: shirady <[email protected]>
(cherry picked from commit 5341fa6)
@shirady shirady removed the request for review from jackyalbo March 6, 2025 06:10
@shirady shirady requested a review from achouhan09 March 10, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant