Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NC | lifecycle | add option to abort multiple uploads #8853

Merged
merged 1 commit into from
Mar 9, 2025
Merged

NC | lifecycle | add option to abort multiple uploads #8853

merged 1 commit into from
Mar 9, 2025
+302 −23

Conversation

nadavMiz
Copy link
Contributor

@nadavMiz nadavMiz commented Mar 5, 2025 •
edited
Loading

Explain the changes

  1. added builder function for lifecycle filter
  2. added lifecycle rule to abort multipart upload
  3. changed delete-candidates to be an object (candidate) containing both delete candidates and abort mpu candidates
  4. added function to abort list of filtered mpus
  5. added test file test_nc_lifecycle_cli.test.js

Issues: Fixed #xxx /

continuation of #8839

Testing Instructions:

  1. run sudo npx jest test_nc_lifecycle_cli
  • Doc added/updated
  • Tests added

@pull-request-size pull-request-size bot added size/L and removed size/XL labels Mar 5, 2025
@pull-request-size pull-request-size bot added size/M and removed size/L labels Mar 5, 2025
@nadavMiz nadavMiz force-pushed the nadav-filters branch 2 times, most recently from eb26502 to 49fac8b Compare March 5, 2025 12:51
@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 5, 2025
@nadavMiz nadavMiz force-pushed the nadav-filters branch 3 times, most recently from 1600101 to d82a4fb Compare March 5, 2025 16:11
@nadavMiz nadavMiz self-assigned this Mar 5, 2025
@nadavMiz nadavMiz force-pushed the nadav-filters branch 4 times, most recently from eed7a01 to 16c8ba8 Compare March 6, 2025 14:02
romayalon
romayalon reviewed Mar 6, 2025
View reviewed changes
@nadavMiz nadavMiz force-pushed the nadav-filters branch 3 times, most recently from 97bd372 to 8e3376f Compare March 9, 2025 11:11
@nadavMiz nadavMiz requested a review from romayalon March 9, 2025 14:21
romayalon
romayalon approved these changes Mar 9, 2025
View reviewed changes
Copy link
Contributor

@romayalon romayalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, please fix before merging

@nadavMiz nadavMiz mentioned this pull request Mar 9, 2025
Open
12 tasks
@nadavMiz nadavMiz merged commit d908885 into noobaa:master Mar 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romayalon romayalon romayalon approved these changes

Assignees

@nadavMiz nadavMiz

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nadavMiz @romayalon