Fix to accept string based primary keys #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primary Key can anything not only `Integer`. For example [`UUID4`](https://docs.djangoproject.com/en/1.8/ref/models/fields/#uuidfield)
|
Hi @Alir3z4, thanks for the PR. Unfortunately It still doesn't pass on the test suite, and it would also be useful to add a test for it (e.g. create a model with non-integer PK, index it in Xapian, and query it. |
|
Superseded by #163. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary Key can be anything not only
Integer.For example
UUID4