Skip to content

Override to fix catalog search links - #662

Merged
laritakr merged 1 commit into
mainfrom
temp-override-for-catalog-links
May 26, 2026
Merged

Override to fix catalog search links#662
laritakr merged 1 commit into
mainfrom
temp-override-for-catalog-links

Conversation

@laritakr

Copy link
Copy Markdown
Member

Summary

  • Result-list links for properties like Creator, Contributor, and Type now find the work they came from when clicked.

Details

  • On the search results page, clicking a Creator or Type value used to drop you on an empty page. The link was searching the wrong field, so the value never matched anything.
  • The override builds the link against the actual indexed value, the same way the work detail page already does.
  • Properties that have a facet panel in the sidebar (Creator, Contributor, Subject, Type, Keyword, etc.) now produce a facet-filter link, matching how those facets behave when picked from the sidebar.
  • A fix is needed in Hyrax so this workaround can be removed later.

Ref samvera/hyku#3072

@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown

Test Results

      4 files  ±0        4 suites  ±0   52s ⏱️ -7s
105 062 tests ±0  105 059 ✅ ±0  3 💤 ±0  0 ❌ ±0 
    395 runs  ±0      392 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit f3bcb1f. ± Comparison against base commit 36b3f3a.

♻️ This comment has been updated with latest results.

Hyrax has several bugs related to catalog search results item
links. `render_as: faceted` should work but may be sticky unless
the app is restarted, and `render_as: linked` produces links
that are not correct (using the property rather than the indexed term.)
@laritakr
laritakr force-pushed the temp-override-for-catalog-links branch from 57ecce9 to f3bcb1f Compare May 26, 2026 21:17
@laritakr
laritakr merged commit 197bff4 into main May 26, 2026
15 checks passed
@laritakr
laritakr deleted the temp-override-for-catalog-links branch May 26, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants