I2 knapsack pals #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit documents the need for Knapsack to reference a branch; as well as provides documentation for doing so.
🧹 Configure Knapsack to Use Hyku Prime
references hyrax-webapp[tags/v5.2.0]. Required to get the build/pipeline working.
Get the build working
Do we need to contribute back TextFileTextExtractionService? ref: - https://github.com/scientist-softserv/adventist_knapsack/blob/1321d31e4f36cb1bde420f1168f4a174ef3c1712/app/services/adventist/text_file_text_extraction_service.rb#L8
pull in updates from hyku_knapsack prime
commit: samvera-labs/hyku_knapsack@5a7c54c which wasn't intentional bumped rails to 7+
This reverts commit 0363299.
This reverts commit 5a7c54c.
get fixes from adventist
fix image urls
jeremyf
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates pals knapsack with prime/main (hyku_knapsack) to fix the build issues