stb_image_write: fix linker errors in HDR image functions when STBI_WRITE_NO_STDIO is defined#1959
Open
sanjay-nambiar wants to merge 2 commits into
Open
Conversation
…WRITE_NO_STDIO defined
Owner
|
Do not borrow from stb_sprintf; that function is not designed to be simple, but to be fast, and we don't need speed here. A much shorter function will do. |
Author
|
Updated the function to be a much simpler one. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling any of the HDR image write functions with
STBI_WRITE_NO_STDIOdefined results in an undefined symbol linker error. This is because all the HDR write function definitions are guarded withSTBI_WRITE_NO_STDIOmacro when only the function that writes directly to a file -stbi_write_hdrshould be under the include guard.Fixing this requires removing one usage of
sprintfused when writing an HDR image header. Implemented a simple unsigned int to string function to replacesprintf, borrowing code fromstb_sprintf.