[stb_vorbis] Increase setup_malloc size parameter to uint64.#1960
Open
AliceLR wants to merge 1 commit into
Open
[stb_vorbis] Increase setup_malloc size parameter to uint64.#1960AliceLR wants to merge 1 commit into
AliceLR wants to merge 1 commit into
Conversation
Expands the setup_malloc size parameter, and various calculations that the Vorbis spec allows to exceed 32 bits, to uint64. setup_malloc and setup_temp_malloc now reject allocations that exceed INT_MAX, as the underlying memory fields are still 32 bit signed integers.
Author
|
sezero
pushed a commit
to sezero/libxmp
that referenced
this pull request
Jun 5, 2026
Expands the setup_malloc size parameter, and various calculations that the Vorbis spec allows to exceed 32 bits, to uint64. setup_malloc and setup_temp_malloc still reject allocations that exceed INT_MAX, as the underlying memory fields are still 32 bit signed integers. Mainstream P/R: nothings/stb#1960 Reference issue: libxmp#996 Also see: nothings/stb#1947 Also see: nothings/stb#1933 Also see: nothings/stb#1168 (comment)
sezero
pushed a commit
to sezero/libxmp
that referenced
this pull request
Jun 5, 2026
Expands the setup_malloc size parameter, and various calculations that the Vorbis spec allows to exceed 32 bits, to uint64. setup_malloc and setup_temp_malloc still reject allocations that exceed INT_MAX, as the underlying memory fields are still 32 bit signed integers. Mainstream P/R: nothings/stb#1960 Reference issue: libxmp#996 Also see: nothings/stb#1947 Also see: nothings/stb#1933 Also see: nothings/stb#1168 (comment)
AliceLR
added a commit
to libxmp/libxmp
that referenced
this pull request
Jun 5, 2026
Expands the setup_malloc size parameter, and various calculations that the Vorbis spec allows to exceed 32 bits, to uint64. setup_malloc and setup_temp_malloc still reject allocations that exceed INT_MAX, as the underlying memory fields are still 32 bit signed integers. Mainstream P/R: nothings/stb#1960 Reference issue: #996 Also see: nothings/stb#1947 Also see: nothings/stb#1933 Also see: nothings/stb#1168 (comment) Co-authored-by: AliceLR <petrifiedrowan@gmail.com>
sezero
pushed a commit
to sezero/stb
that referenced
this pull request
Jun 5, 2026
Expands the setup_malloc size parameter, and various calculations that the Vorbis spec allows to exceed 32 bits, to uint64. setup_malloc and setup_temp_malloc still reject allocations that exceed INT_MAX, as the underlying memory fields are still 32 bit signed integers. Reference issue: libxmp/libxmp#996 Reference issue: nothings#1947 Reference issue: nothings#1933 Also see : nothings#1168 (comment) Mainstream P/R : nothings#1960
sezero
pushed a commit
to icculus/SDL_sound
that referenced
this pull request
Jun 5, 2026
Expands the setup_malloc size parameter, and various calculations that the Vorbis spec allows to exceed 32 bits, to uint64. setup_malloc and setup_temp_malloc still reject allocations that exceed INT_MAX, as the underlying memory fields are still 32 bit signed integers. Reference issue: libxmp/libxmp#996 Reference issue: nothings/stb#1947 Reference issue: nothings/stb#1933 Also see : nothings/stb#1168 (comment) Mainstream P/R : nothings/stb#1960 (cherry picked from commit 19ae8a8)
sezero
pushed a commit
to icculus/SDL_sound
that referenced
this pull request
Jun 5, 2026
Expands the setup_malloc size parameter, and various calculations that the Vorbis spec allows to exceed 32 bits, to uint64. setup_malloc and setup_temp_malloc still reject allocations that exceed INT_MAX, as the underlying memory fields are still 32 bit signed integers. Reference issue: libxmp/libxmp#996 Reference issue: nothings/stb#1947 Reference issue: nothings/stb#1933 Also see : nothings/stb#1168 (comment) Mainstream P/R : nothings/stb#1960
sezero
pushed a commit
to libsdl-org/SDL_mixer
that referenced
this pull request
Jun 5, 2026
Expands the setup_malloc size parameter, and various calculations that the Vorbis spec allows to exceed 32 bits, to uint64. setup_malloc and setup_temp_malloc still reject allocations that exceed INT_MAX, as the underlying memory fields are still 32 bit signed integers. Reference issue: libxmp/libxmp#996 Reference issue: nothings/stb#1947 Reference issue: nothings/stb#1933 Also see : nothings/stb#1168 (comment) Mainstream P/R : nothings/stb#1960 (cherry picked from commit 369279b)
sezero
pushed a commit
to libsdl-org/SDL_mixer
that referenced
this pull request
Jun 5, 2026
Expands the setup_malloc size parameter, and various calculations that the Vorbis spec allows to exceed 32 bits, to uint64. setup_malloc and setup_temp_malloc still reject allocations that exceed INT_MAX, as the underlying memory fields are still 32 bit signed integers. Reference issue: libxmp/libxmp#996 Reference issue: nothings/stb#1947 Reference issue: nothings/stb#1933 Also see : nothings/stb#1168 (comment) Mainstream P/R : nothings/stb#1960
sezero
pushed a commit
to libsdl-org/SDL_mixer
that referenced
this pull request
Jun 5, 2026
Expands the setup_malloc size parameter, and various calculations that the Vorbis spec allows to exceed 32 bits, to uint64. setup_malloc and setup_temp_malloc still reject allocations that exceed INT_MAX, as the underlying memory fields are still 32 bit signed integers. Reference issue: libxmp/libxmp#996 Reference issue: nothings/stb#1947 Reference issue: nothings/stb#1933 Also see : nothings/stb#1168 (comment) Mainstream P/R : nothings/stb#1960 (cherry picked from commit 369279b)
sezero
pushed a commit
to libsdl-org/SDL_mixer
that referenced
this pull request
Jun 5, 2026
Expands the setup_malloc size parameter, and various calculations that the Vorbis spec allows to exceed 32 bits, to uint64. setup_malloc and setup_temp_malloc still reject allocations that exceed INT_MAX, as the underlying memory fields are still 32 bit signed integers. Reference issue: libxmp/libxmp#996 Reference issue: nothings/stb#1947 Reference issue: nothings/stb#1933 Also see : nothings/stb#1168 (comment) Mainstream P/R : nothings/stb#1960
sezero
pushed a commit
to libsdl-org/SDL_mixer
that referenced
this pull request
Jun 5, 2026
Expands the setup_malloc size parameter, and various calculations that the Vorbis spec allows to exceed 32 bits, to uint64. setup_malloc and setup_temp_malloc still reject allocations that exceed INT_MAX, as the underlying memory fields are still 32 bit signed integers. Reference issue: libxmp/libxmp#996 Reference issue: nothings/stb#1947 Reference issue: nothings/stb#1933 Also see : nothings/stb#1168 (comment) Mainstream P/R : nothings/stb#1960 (cherry picked from commit 52afb20)
Wohlstand
added a commit
to WohlSoft/SDL-Mixer-X
that referenced
this pull request
Jun 5, 2026
Backported from libsdl-org/SDL_mixer@369279b xpands the setup_malloc size parameter, and various calculations that the Vorbis spec allows to exceed 32 bits, to uint64. setup_malloc and setup_temp_malloc still reject allocations that exceed INT_MAX, as the underlying memory fields are still 32 bit signed integers. Reference issue: libxmp/libxmp#996 Reference issue: nothings/stb#1947 Reference issue: nothings/stb#1933 Also see : nothings/stb#1168 (comment) Mainstream P/R : nothings/stb#1960
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marking as a draft for now since it's poorly tested, but this should fix #1933, #1947, and the second case in the comment #1168 (comment). However, it's not clear if this is the fix you actually want (particularly re: the definition of
uint64and various type-corrections).@nothings I've noticed several dubious submissions duplicating parts of bug reports and patches I submitted years ago. Is there anything I can do to help?