Open
Conversation
add handling to detect and read some description.html
Updates template to read and display description.html if exists
Update light mode template to display description.html if exists
Member
|
Thank you very much! 👍 Thats a great idea and will be included in v2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I am testing this gallery out and it seems to be just what I want, it's very nice thank you!
I have never written PHP before, so please bear with my naivete. I wanted to see if I could include some small information on an album basis; for example, if it's pictures related to a trip, write a few sentences about the trip and include an embed of the google maps trip, something like that. It's related to #17.
It seemed to me easy to just have a
description.htmlfile in each album folder, and if it has content, then display that content.Not the most user-friendly, but writing a little bit of HTML isn't a huge ask nowadays I suppose. I tested that it works on my website.
I suppose to make it more robust and easier for people maybe adding a markdown conversion process so that the user doesn't have to worry about syntax errors in the html, they would just supply a description.md file in each album. But I guess I also like the low-dependency approach used here.
Anyway, it works for my purposes but obviously I haven't spent a lot of time thinking about a general solution to the problem or any problems associated with how this has been written, so I'm mainly writing this in case it can be useful for another user to patch into their code, with no expectation that it should be merged.
Thanks for the discussion!