Skip to content

feat: add configurable ignore_keys setting to filter key events #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tjasko wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add configurable ignore_keys setting to filter key events #2047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 81 additions & 1 deletion app/styles/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,14 +612,17 @@ html {
list-style: none;
padding: 0px;
}
#noVNC_settings button,
#noVNC_settings select,
#noVNC_settings textarea,
#noVNC_settings input:not([type=checkbox]):not([type=radio]) {
margin-left: 6px;
/* Prevent inputs in settings from being too wide */
max-width: calc(100% - 6px - var(--input-xpadding) * 2);
}
#noVNC_settings button:not(#noVNC_ignore_keys_help_button) {
margin-left: 6px;
max-width: calc(100% - 6px - var(--input-xpadding) * 2);
}

#noVNC_setting_port {
width: 80px;
Expand All @@ -643,6 +646,83 @@ html {
display: none;
}

/* Help tooltips */
.noVNC_setting_with_help {
position: relative;
display: flex;
align-items: center;
gap: 0.4rem;
}

.noVNC_setting_with_help label {
flex: 0 1 auto;
}

#noVNC_settings .noVNC_tooltip_list {
margin: 0.4rem 0 0 0;
padding-left: 0.8rem;
list-style: disc;
}

.noVNC_tooltip_list li {
margin: 0.15rem 0;
}

#noVNC_setting_ignore_keys::placeholder {
color: var(--novnc-grey);
opacity: 0.7;
}

#noVNC_setting_ignore_keys.noVNC_invalid,
#noVNC_setting_ignore_keys.noVNC_invalid:focus {
border-color: var(--novnc-red);

@samhed samhed Apr 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why we need our own color for this, regular "red" looks fine.

box-shadow: 0 0 2px rgba(var(--novnc-red-rgb), 0.5);
}

#noVNC_ignore_keys_help_button {
flex: 0 0 auto;

width: 1.6rem;
height: 1.6rem;
min-width: 1.6rem;
max-width: 1.6rem;

padding: 0;
margin: 0;

border-radius: 50%;
background: transparent;
border: 1px solid rgba(0,0,0,0.25);
cursor: pointer;

display: inline-flex;
align-items: center;
justify-content: center;

line-height: 1;
}

#noVNC_ignore_keys_tooltip {
display: none;
position: absolute;
z-index: 1000;
left: 1rem;
padding: 0.5rem;
margin: 0;
border-radius: 0.4rem;
background: rgba(20, 20, 20, 0.96);
color: #fff;
box-shadow: 0 0.4rem 1rem rgba(0, 0, 0, 0.35);
font-size: 0.75rem;
line-height: .9rem;
}

#noVNC_ignore_keys_tooltip.noVNC_open {
display: flex !important;
flex-direction: column;
align-items: flex-start;
}

/* ----------------------------------------
* Status dialog
* ----------------------------------------
Expand Down
2 changes: 2 additions & 0 deletions app/styles/constants.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@

--novnc-green: rgb(0, 128, 0);
--novnc-yellow: rgb(255, 255, 0);
--novnc-red-rgb: 229, 57, 53;
--novnc-red: rgb(var(--novnc-red-rgb));
}

/* ------ MISC PROPERTIES ------ */
Expand Down
Loading