Add initing of ls pins #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @emericklaw! Thank you, I need to test this and don't currently have my badge, I'll get back to this in a few days though :) |
|
This should actually wait for emfcamp/badge-2024-software#166 since this is a better implementation of what I did in emfcamp/badge-2024-software#174 If all goes well the changes in this pull request should still work. |
|
This works with the changes to LS pins in 1.9.0-beta.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this app and had to get it to help with testing, however the LS pins did not work.
In this pull request emfcamp/badge-2024-software#174 I made the LS pins better mimic standard machine.pins