Skip to content

samples: openthread: Adding HCI capabilities in RCP sample. #12904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

canisLupus1313
Copy link

Commit adds hci functionality to openthread coprocessor sample.

@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest labels Oct 30, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 30, 2023

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@90a72da nrfconnect/sdk-zephyr@0c7fcf3 (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@canisLupus1313 canisLupus1313 force-pushed the rcp_hci branch 5 times, most recently from e36f588 to 25e059c Compare October 30, 2023 13:42
Copy link
Member

@maciejbaczmanski maciejbaczmanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion on including HCI files only if overlay is chosen in subcomments.

Regarding .conf and .overlay files, they can be moved to snippets/hci directory after #12909 .
In the same directory, snippet.yml should be created, containing:

name: hci
append:
  EXTRA_CONF_FILE: hci.conf
  EXTRA_DTC_OVERLAY_FILE: hci.overlay

and in sample.yaml line:

extra_args: OVERLAY_CONFIG=overlay-hci.conf DTC_OVERLAY_FILE="rcp_hci.overlay"

changed to

extra_args: SNIPPET=hci

@canisLupus1313 canisLupus1313 force-pushed the rcp_hci branch 3 times, most recently from 76efae4 to 761ab5e Compare November 14, 2023 16:35
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Nov 14, 2023
@canisLupus1313 canisLupus1313 marked this pull request as ready for review November 14, 2023 16:37
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 14, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X
test-fw-nrfconnect-fem X
test-fw-nrfconnect-rpc X
test-fw-nrfconnect-rs X
test-fw-nrfconnect-thread X
test-sdk-find-my X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@canisLupus1313 canisLupus1313 force-pushed the rcp_hci branch 3 times, most recently from 7d68d1e to 7b73072 Compare November 16, 2023 21:41
Copy link
Contributor

@edmont edmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice feature, but should we cover it with some specific testing?

@edmont edmont requested a review from wiba-nordic November 17, 2023 08:00
@canisLupus1313 canisLupus1313 force-pushed the rcp_hci branch 2 times, most recently from 473aa57 to 49107bb Compare November 24, 2023 09:49
Commit adds hci functionality to openthread coprocessor sample.

Signed-off-by: Przemyslaw Bida <[email protected]>
@NordicBuilder NordicBuilder removed the DNM label Nov 24, 2023
@nordicjm nordicjm merged commit 12575d5 into nrfconnect:main Nov 27, 2023
@canisLupus1313 canisLupus1313 deleted the rcp_hci branch June 6, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. manifest manifest-zephyr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants