-
Notifications
You must be signed in to change notification settings - Fork 1.3k
samples: openthread: Adding HCI capabilities in RCP sample. #12904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
e36f588
to
25e059c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion on including HCI files only if overlay is chosen in subcomments.
Regarding .conf
and .overlay
files, they can be moved to snippets/hci
directory after #12909 .
In the same directory, snippet.yml
should be created, containing:
name: hci
append:
EXTRA_CONF_FILE: hci.conf
EXTRA_DTC_OVERLAY_FILE: hci.overlay
and in sample.yaml
line:
extra_args: OVERLAY_CONFIG=overlay-hci.conf DTC_OVERLAY_FILE="rcp_hci.overlay"
changed to
extra_args: SNIPPET=hci
76efae4
to
761ab5e
Compare
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
7d68d1e
to
7b73072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice feature, but should we cover it with some specific testing?
7b73072
to
1d1fe56
Compare
1d1fe56
to
76b16a2
Compare
76b16a2
to
0175e9f
Compare
0175e9f
to
3ee8b59
Compare
473aa57
to
49107bb
Compare
49107bb
to
0d64362
Compare
Commit adds hci functionality to openthread coprocessor sample. Signed-off-by: Przemyslaw Bida <[email protected]>
0d64362
to
4df5362
Compare
Commit adds hci functionality to openthread coprocessor sample.