Add support for BSSID configuration in connect call. #14654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rado17
requested review from
sachinthegreen,
ajayparida,
D-Triveni,
VivekUppunda and
kapbh
rado17
requested review from
krish2718,
jukkar,
rlubos,
carlescufi and
tejlmand
as code owners
github-actions
bot
added
manifest
changelog-entry-required
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
sachinthegreen
approved these changes
Apr 4, 2024
rado17
force-pushed
the
connect_getopt_support
branch
2 times, most recently
from
05bfffa to
c99d872
Compare
krish2718
reviewed
Apr 5, 2024
rado17
force-pushed
the
connect_getopt_support
branch
2 times, most recently
from
da5ce97 to
019d5b9
Compare
rado17
force-pushed
the
connect_getopt_support
branch
from
019d5b9 to
0c99cc2
Compare
VivekUppunda
approved these changes
Apr 10, 2024
kapbh
approved these changes
Apr 10, 2024
rado17
force-pushed
the
connect_getopt_support
branch
2 times, most recently
from
392fccd to
042decc
Compare
krish2718
reviewed
Apr 15, 2024
rado17
force-pushed
the
connect_getopt_support
branch
2 times, most recently
from
c8a94db to
287a547
Compare
krish2718
approved these changes
Apr 16, 2024
| @@ -403,6 +404,25 @@ static int wpas_add_and_config_network(struct wpa_supplicant *wpa_s, | |||
| } | |||
| } | |||
|
|
|||
| memcpy((void *)&mac, params->bssid, WIFI_MAC_ADDR_LEN); | |||
| if (net_eth_is_addr_broadcast(&mac) || | |||
There was a problem hiding this comment.
You move this check in to the below branch (!unspecified)
There was a problem hiding this comment.
!unspecified checks for all 0s which is equivalent to not setting the BSSID. That is why I am returning error only for broadcast and multicast case.
rado17
force-pushed
the
connect_getopt_support
branch
from
287a547 to
b57e925
Compare
jukkar
approved these changes
Apr 16, 2024
rado17
force-pushed
the
connect_getopt_support
branch
from
b57e925 to
e927fdf
Compare
|
@rado17 Needs a rebase. |
Pull in changes done to support getopt for Wi-Fi connect command as well as additional support to configure BSSID in connect command. Signed-off-by: Ravi Dondaputi <[email protected]>
Support BSSID configuration while setting up the network information as part of the connect command processing. Signed-off-by: Ravi Dondaputi <[email protected]>
Calls for Wi-Fi related operations from shell are quite deep (around 7 levels) which eats up the available stack and causes stack overflow issues. Increase the SHELL_STACK_SIZE to account for this. Signed-off-by: Ravi Dondaputi <[email protected]>
rado17
force-pushed
the
connect_getopt_support
branch
from
e927fdf to
263c41a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_wifi: sdk-nrf-pr-14626