-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging: allow storing log history in flash #20167
Conversation
Damian-Nordic
commented
Feb 3, 2025
- When CONFIG_LOG_BACKEND_RPC_HISTORY_STORAGE_FCB option is set, define the "log_history" flash partition and enable storing the log history using Flash Circular Buffer.
- samples: nrf_rpc: ps_server: enable partition manager
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: f23a3ad7ee9364b2f94b51f473a7e20ec8fe6e4e more detailssdk-nrf:
Github labels
List of changed files detected by CI (10)
Outputs:ToolchainVersion: 342151af73 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR at this link. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
40b3057
to
d625337
Compare
562b8ac
to
a04fa83
Compare
@nordicjm could you please re-review? |
a04fa83
to
3e8b9ee
Compare
We need partition manager to easily add a partition for storing the log history on demand. Signed-off-by: Damian Krolik <[email protected]>
When CONFIG_LOG_BACKEND_RPC_HISTORY_STORAGE_FCB option is set, define the "log_history" flash partition and enable storing the log history using Flash Circular Buffer. Signed-off-by: Damian Krolik <[email protected]>
3e8b9ee
to
f23a3ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)