Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysbuild: Specify BOARD if the main image sets it #20318

Merged

Conversation

tomchy
Copy link
Contributor

@tomchy tomchy commented Feb 12, 2025

It is necessary to configure the BOARD variable as fast as possible, since there are scritps (i.e. UICR generation) that uses this value and fail otherwise.

Ref: NCSDK-3012

It is necessary to configure the BOARD variable as fast as possible,
since there are scritps (i.e. UICR generation) that uses this value and
fail otherwise.

Ref: NCSDK-3012

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@tomchy tomchy requested a review from a team as a code owner February 12, 2025 15:10
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 12, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 12, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: dcc6436894ec44ef10be397a4dc2ee5fda1f1cd0

more details

sdk-nrf:

PR head: dcc6436894ec44ef10be397a4dc2ee5fda1f1cd0
merge base: 06cc13ea266d44d92c44a8065a8fa3b0554bfedf
target head (main): a1a9f4429536ade819dff062b0a03cbe2c8b6ca8
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
cmake
│  ├── sysbuild
│  │  ├── modules
│  │  │  │ ncs_sysbuild_extensions.cmake

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_bbe5b33786

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • ✅ Integration tests
    • ✅ test-sdk-audio
    • ✅ desktop52_verification
    • ✅ test-fw-nrfconnect-boot
    • ✅ test-fw-nrfconnect-apps
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_mesh
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m
    • ✅ doc-internal
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-proprietary_esb
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-tfm
    • ✅ test-fw-nrfconnect-thread
    • ✅ test-fw-nrfconnect-zigbee
    • ✅ test-sdk-find-my
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
    • ✅ test-sdk-sidewalk
    • ✅ test-sdk-wifi
    • ✅ test-low-level
    • ✅ test-sdk-pmic-samples
    • ✅ test-sdk-mcuboot
    • ✅ test-sdk-dfu
    • ✅ test-fw-nrfconnect-ps
    • ✅ test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zdebug.uart.kmu_provision[nrf54l15dk/nrf54l15/cpuapp]: ROM size increased by 5566[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52833dongle/nrf52833]: ROM size increased by 11543[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_keyboard.uart.kmu_provision[nrf54l15dk/nrf54l15/cpuapp]: ROM size increased by 6154[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug.uart[nrf54h20dk/nrf54h20/cpuapp]: ROM size increased by 10710[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug.usb_next[nrf52840gmouse/nrf52840]: ROM size increased by 6647[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_fast_pair.gmouse.uart.kmu_provision[nrf54l15dk/nrf54l15/cpuapp]: ROM size increased by 7513[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug.usb_next[nrf52840dongle/nrf52840]: ROM size increased by 12919[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52840dk/nrf52840]: ROM size increased by 7070[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52840gmouse/nrf52840]: ROM size increased by 5623[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_4llpmconn[nrf52840dongle/nrf52840]: ROM size increased by 11727[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_dongle.usb_next[nrf52840dk/nrf52840]: ROM size increased by 13271[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_fast_pair.gmouse[nrf52840gmouse/nrf52840]: ROM size increased by 8243[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_nrf21540ek_multicore[nrf5340dk/nrf5340/cpuapp]: ROM size increased by 12623[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf5340dk/nrf5340/cpuapp]: ROM size increased by 11955[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease_keyboard[nrf54l15dk/nrf54l05/cpuapp]: ROM size increased by 6938[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug.usb_next[nrf52840dk/nrf52840]: ROM size increased by 8210[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_mcuboot_qspi[nrf52840dk/nrf52840]: ROM size increased by 6894[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_mcuboot_smp[nrf52840dk/nrf52840]: ROM size increased by 8082[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebugwithshell[nrf52840dk/nrf52840]: ROM size increased by 7918[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease.usb_next[nrf52840dk/nrf52840]: ROM size increased by 7518[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf52840dongle/nrf52840]: ROM size increased by 10735[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf52840gmouse/nrf52840]: ROM size increased by 8571[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52833dk/nrf52833]: ROM size increased by 11755[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf54l15dk/nrf54l05/cpuapp]: ROM size increased by 5410[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug.uart.kmu_provision[nrf54l15dk/nrf54l10/cpuapp]: ROM size increased by 5542[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52840dongle/nrf52840]: ROM size increased by 11867[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_nrf21540ek[nrf52840dk/nrf52840]: ROM size increased by 7026[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf54l15dk/nrf54l15/cpuapp]: ROM size increased by 4270[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_wwcb[nrf52840dk/nrf52840]: ROM size increased by 7482[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf54h20dk/nrf54h20/cpuapp]: ROM size increased by 14466[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf5340dk/nrf5340/cpuapp]: ROM size increased by 12623[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug_dongle[nrf52840dk/nrf52840]: ROM size increased by 12075[B] in comparison to the main[71b516c] branch. - link (cc: @MarekPieta)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-20318/1)

@tomchy tomchy requested a review from robertstypa February 13, 2025 12:45
@tomchy tomchy merged commit 6d3f9f4 into nrfconnect:main Feb 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants